[Webkit-unassigned] [Bug 259260] New: Remove 'didChangeScrollOffset' from RenderLayerScrollableArea::scrollTo()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=259260

            Bug ID: 259260
           Summary: Remove 'didChangeScrollOffset' from
                    RenderLayerScrollableArea::scrollTo()
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: bfulgham at webkit.org, simon.fraser at apple.com,
                    zalan at apple.com

Hi Team,

While going through Blink's commit, I came across one revert change of bug 110673.

^ @Simon's reviewed patch landed in above as following: http://trac.webkit.org/changeset/146260

Blink Commit: https://src.chromium.org/viewvc/blink?view=revision&revision=148242

WebKit's Source https://github.com/WebKit/WebKit/blob/638ac8184b3860aafc3d68fec13300730af06a6d/Source/WebCore/rendering/RenderLayerScrollableArea.cpp#L424

_______

It was revert because of following:

"This is simply wrong. Something scrolled != the frame scrolled.
Actually RenderLayer can be anything but the frame."

_______

I reverted it locally and it compiles. (Not run 'run-webkit-tests' because I have other scrolling patches as well).

_________

So I just wanted to raise and get input, whether we can remove it as well.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230716/cf3263f1/attachment.htm>