[Webkit-unassigned] [Bug 259254] New: Correctly identify overflow direction inside flexbox

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jul 15 20:48:28 PDT 2023


https://bugs.webkit.org/show_bug.cgi?id=259254

            Bug ID: 259254
           Summary: Correctly identify overflow direction inside flexbox
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Keywords: BrowserCompat, WPTImpact
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: bfulgham at webkit.org, simon.fraser at apple.com,
                    zalan at apple.com

Hi Team,

While looking into Flexbox failure, came across following failing WPT test:

Live Link: http://wpt.live/css/css-flexbox/overflow-top-left.html

Blink Commit: https://chromium-review.googlesource.com/c/chromium/src/+/1618017

WebKit Source: https://github.com/WebKit/WebKit/blob/3ae98fa2c02b272e3e55c4e0c324d01da17cb5dc/Source/WebCore/rendering/RenderFlexibleBox.cpp#L2502

________

I tried changing to this:

bool RenderFlexibleBox::isTopLayoutOverflowAllowed() const
{
    auto flexDirection = style().flexDirection();
    if (isHorizontalWritingMode())
        return flexDirection == FlexDirection::ColumnReverse;
    return !style().isLeftToRightDirection() ^ (flexDirection == FlexDirection::RowReverse);
}

bool RenderFlexibleBox::isLeftLayoutOverflowAllowed() const
{
    auto flexDirection = style().flexDirection();
    if (isHorizontalWritingMode())
        return flexDirection == FlexDirection::RowReverse;
    return !style().isLeftToRightDirection() ^ (flexDirection == FlexDirection::ColumnReverse);
}

_______

Although this does not fix the test case but still good to track.

Hence, I am raising it and adding 'BrowserCompat' and 'WPTImpact' tags.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230716/b31ea1ea/attachment.htm>


More information about the webkit-unassigned mailing list