[Webkit-unassigned] [Bug 259244] New: Don't read 'm_bitMasks' when it's not supposed to be meaningful

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jul 15 10:07:09 PDT 2023


https://bugs.webkit.org/show_bug.cgi?id=259244

            Bug ID: 259244
           Summary: Don't read 'm_bitMasks' when it's not supposed to be
                    meaningful
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Keywords: DoNotImportToRadar
          Severity: Normal
          Priority: P2
         Component: Images
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: don.olmstead at sony.com, Hironori.Fujii at sony.com,
                    sabouhallawa at apple.com

Hi Team,

This is just merge of following:

https://src.chromium.org/viewvc/blink?view=revision&revision=193289

It is partial merge that we don't have implemented other change, where we have to get rid of stuff. It is just initialization optimization to initiate 'm_bitMasks' in applicable case (i.e., less than 16).

WebKit Source: https://github.com/WebKit/WebKit/blob/3a311fd2cd7e267ba71dca49060ad2c6be31f36d/Source/WebCore/platform/image-decoders/bmp/BMPImageReader.cpp#L103

This:

if ((m_andMaskState == NotYetDecoded) && !m_buffer->hasAlpha() && (m_infoHeader.biBitCount < 16)) {

It compiles.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230715/12723d15/attachment-0001.htm>


More information about the webkit-unassigned mailing list