[Webkit-unassigned] [Bug 259010] New: Remove duplicate check in 'checkInvalidControlsAndCollectUnhandled' function 'if' clause

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jul 8 01:03:40 PDT 2023


https://bugs.webkit.org/show_bug.cgi?id=259010

            Bug ID: 259010
           Summary: Remove duplicate check in
                    'checkInvalidControlsAndCollectUnhandled' function
                    'if' clause
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Forms
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: cdumez at apple.com, wenson_hsieh at apple.com

Bug to remove duplicate check from this:

https://github.com/WebKit/WebKit/blob/da535631d69cc22753758c77b058981ee8bb3e09/Source/WebCore/html/HTMLFormElement.cpp#L811

We have:

if (control->form() == this && !control->checkValidity(&unhandledInvalidControls) && control->form() == this)

Which can be just:

if (!control->checkValidity(&unhandledInvalidControls) && control->form() == this)

______

Just raising to fix this.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230708/aa63a484/attachment.htm>


More information about the webkit-unassigned mailing list