[Webkit-unassigned] [Bug 258908] New: [modern-media-controls] Stop setting CSS variables using universal selectors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=258908

            Bug ID: 258908
           Summary: [modern-media-controls] Stop setting CSS variables
                    using universal selectors
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Media
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ntim at apple.com
                CC: webkit-bug-importer at group.apple.com

Variables should be set on the container element and inherited down. They shouldn't be set on every single element like:

https://searchfox.org/wubkat/rev/12cb9f518180ff4a469eff2481efdf907e4cf63c/Source/WebCore/Modules/modern-media-controls/controls/media-controls.css#38-44

Rules like these are error prone, because overriding them from different CSS files might not work as expected. See for instance:

https://searchfox.org/wubkat/rev/12cb9f518180ff4a469eff2481efdf907e4cf63c/Source/WebCore/Modules/modern-media-controls/controls/vision-media-controls.css#34-41

which needs to do `.media-controls.vision *`.

If someone writes a new rule and forgets the `*` or misses an element where the variable is used, this can cause issues with the variable having the wrong value.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230706/71399f61/attachment.htm>