[Webkit-unassigned] [Bug 105260] table-caption stride over pages.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 4 16:56:25 PDT 2023
https://bugs.webkit.org/show_bug.cgi?id=105260
--- Comment #13 from Ahmad Saleem <ahmad.saleem792 at gmail.com> ---
RenderTable.cpp: (Simple Change) on Line 286
// Apply the margins to the location now that they are definitely available from layout
LayoutUnit captionLogicalTop = collapsedMarginBeforeForChild(caption) + logicalHeight();
caption.setLogicalLocation(LayoutPoint(caption.marginStart(), captionLogicalTop));
______________
RenderBlockFlow.cpp changes are bit confusing for me:
https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderBlockFlow.cpp#1900
^ from above remove '&& !isTableCell()'
Static function in Blink (shouldSetStrutOnBlock), does not exist in same shape in WebKit but it exist here in some change / form:
https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderBlockFlow.cpp#2081
______________
Have to create new bool function (allowsPaginationStrut).
_______________________
If someone can guide me on second part, I am happy to look into merging these patches. I am not clear on 'return' bit or I can create new static function but which parts to remove from the linked area.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230704/de323171/attachment.htm>
More information about the webkit-unassigned
mailing list