[Webkit-unassigned] [Bug 257082] Changing 'DisplayType::InlineGrid' and 'DisplayType::InlineFlex' to output properly in StyleAdjuster.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=257082

--- Comment #5 from Ahmad Saleem <ahmad.saleem792 at gmail.com> ---
Creating another 'Static' function in StyleAdjuster.cpp:

static DisplayType equivalentDisplayForLegend(const RenderStyle& style)
{
    switch (auto display = style.display()) {
    case DisplayType::Block:
    case DisplayType::Table:
    case DisplayType::Box:
    case DisplayType::FlowRoot:
    case DisplayType::ListItem:
        return display;
    case DisplayType::InlineTable:
        return DisplayType::Table;
    case DisplayType::InlineBox:
        return DisplayType::InlineBox;
    case DisplayType::Flex:
        return DisplayType::Flex;
    case DisplayType::InlineFlex:
        return DisplayType::InlineFlex;
    case DisplayType::Grid:
        return DisplayType::Grid;
    case DisplayType::InlineGrid:
        return DisplayType::InlineGrid;
    case DisplayType::Inline:
    case DisplayType::InlineBlock:
    case DisplayType::TableRowGroup:
    case DisplayType::TableHeaderGroup:
    case DisplayType::TableFooterGroup:
    case DisplayType::TableRow:
    case DisplayType::TableColumnGroup:
    case DisplayType::TableColumn:
    case DisplayType::TableCell:
    case DisplayType::TableCaption:
        return DisplayType::Block;
    case DisplayType::Contents:
        ASSERT_NOT_REACHED();
        return DisplayType::Contents;
    case DisplayType::None:
        ASSERT_NOT_REACHED();
        return DisplayType::None;
    }
    ASSERT_NOT_REACHED();
    return DisplayType::Block;
}

and then modifying Line 363 to:

style.setEffectiveDisplay(equivalentDisplayForLegend(style));

__________________

@Antti , @Tim , @Alan - any suggestion? It will fix some of these tests.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230704/54ce7cd2/attachment.htm>