[Webkit-unassigned] [Bug 258228] Post Accessibility notifications during composition contexts indicating start, end, and value change.

Sat Jul 1 16:28:09 PDT 2023

https://bugs.webkit.org/show_bug.cgi?id=258228

Tyler Wilcock <tyler_w at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tyler_w at apple.com

--- Comment #5 from Tyler Wilcock <tyler_w at apple.com> ---
Comment on attachment 466889
  --> https://bugs.webkit.org/attachment.cgi?id=466889
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=466889&action=review

> Source/WebCore/accessibility/AXTextMarker.h:179
> +class AXIsolatedTextMarkerRange {

This feels more like a struct than a class. Do you agree, or is there some reason you made it a class?

> LayoutTests/accessibility/mac/text-input-session-notifications.html:7
> +<body>
> +    <input id="editable" type="text">

Everything within the body tag can be indented at the same level as the body itself.

> LayoutTests/accessibility/mac/text-input-session-notifications.html:9
> +    <script type="text/javascript">
> +        description("This test ensures that the input method marked range is available to accessibility clients as text marker range.");

Everything within this script tag can be indented at the same level as the script tag itself.

> LayoutTests/accessibility/mac/text-input-session-notifications.html:39
> +            var element = accessibilityController.accessibleElementById("editable");
> +            
> +            element.addNotificationListener(notificationCallback);

Can probably shorten these two lines to be:

accessibilityController.accessibleElementById("editable").addNotificationListener(notificationCallback);

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230701/4742e683/attachment-0001.htm>