[Webkit-unassigned] [Bug 251426] [GTK][WPE] Clarify the concept of a related web view

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=251426

--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Michael Catanzaro from comment #1)
> (In reply to Carlos Garcia Campos from comment #0)
> > This is confusing, I think
> > webkit_web_view_new_with_related_view() should only pass related-view to
> > g_object_new(). Or maybe we should just remove
> > webkit_web_view_new_with_related_view(), since it seems it's not actually
> > used.
> 
> It only makes sense to keep webkit_web_view_new_with_related_view() if all
> the other construct properties get taken from the related-view.
> 
> > Then clarify in the documentation that a related web view always
> > shares the web-context, network-session/is-ephemeral and
> > is-controlled-by-automation, and passing any of these together with
> > related-view has no effect.
> 
> As long as there's a g_critical() if you do it wrong, sure.

I'm not sure, it's convenient to just pass something even if it's ignored as long as you know it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230131/444edcb5/attachment.htm>