[Webkit-unassigned] [Bug 248144] [GTK4] PlatformKeyboardEvent is discarding modifier state

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=248144

Michael Catanzaro <mcatanzaro at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcatanzaro at gnome.org

--- Comment #2 from Michael Catanzaro <mcatanzaro at gnome.org> ---
(In reply to Alexander Mikhaylenko from comment #1)
> The real question is why it does that instead of having modifiers as part of
> the event already. Like that code was never correct to begin with.

The name of the function, PlatformKeyboardEvent::currentStateOfModifierKeys, is kinda unambiguous, though. It's asking for the *current* state of the modifier keys, not the state of modifier keys corresponding to any particular event. And it is a static function, not a method that operates on a particular event.

Looks like it's used only by DragController.cpp and EventHandler.cpp (plus some platform-specific places that don't affect GTK). In DragController it's used to synthesize mouse events, which looks pretty reasonable. In EventHandler.cpp it's again used to synthesize mouse events in EventHandler::fakeMouseMoveEventTimerFired.

So this code looks decent enough. Only problem is we need to implement it. I wonder if that's even possible with GTK 4.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230130/bb3f05fc/attachment-0001.htm>