[Webkit-unassigned] [Bug 251111] New: StrongInlines.h methods should be marked as "inline" in Strong.h

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 24 13:37:06 PST 2023


https://bugs.webkit.org/show_bug.cgi?id=251111

            Bug ID: 251111
           Summary: StrongInlines.h methods should be marked as "inline"
                    in Strong.h
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: jer.noble at apple.com

Because they're not marked as "inline", if you include Strong.h and use Strong::Strong() or Strong::set() and _don't_ include StrongInlines.h, you will end up with a linker error, as these methods are not exported.

However, adding "inline" to these methods expose a number of build errors. Someone should do the work to mark these as "inline" and clean up all the places where these methods are used without including StrongInlines.h.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230124/b7b57b69/attachment.htm>


More information about the webkit-unassigned mailing list