[Webkit-unassigned] [Bug 251045] AX: Fix for crash in AXIsolatedTree::removeNode.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=251045

--- Comment #7 from Andres Gonzalez <andresg_22 at apple.com> ---
(In reply to Tyler Wilcock from comment #3)
> Comment on attachment 464613 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=464613&action=review
> 
> > Source/WebCore/accessibility/AXObjectCache.cpp:1052
> > +        // The removal needs to be async because this is called during a RenderTree
> > +        // update and remove(AXID) updates the isolated tree that in turn calls
> > +        // parentObjectUnignored() on the object being removed.
> 
> I feel like this comment explanation doesn't go far enough — why is it bad
> to call parentObjectUnignored() on an object that is being removed? I know
> the answer from reading your commit message, but it could be useful to put
> here too.

Expanded comment.
> 
> > Source/WebCore/accessibility/AXObjectCache.cpp:3469
> > +    AXLOG(makeString("RemovedObjects size ", m_deferredRemovedObjects.size()));
> 
> Not something to worry about for this patch, but in my opinion it would be
> nice if these m_deferredFoo log statements in performDeferredCacheUpdate
> didn't print anything unless their size was > 0. Right now they're very
> spammy and make reading the logs quite a bit harder.

Separate bug/patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230124/a950ecc9/attachment.htm>