[Webkit-unassigned] [Bug 251042] New: Editing - Code refactoring to avoid several calls to hasEditableStyle() in loop

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 23 14:27:13 PST 2023


https://bugs.webkit.org/show_bug.cgi?id=251042

            Bug ID: 251042
           Summary: Editing - Code refactoring to avoid several calls to
                    hasEditableStyle() in loop
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: HTML Editing
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: wenson_hsieh at apple.com

Hi Team,

I came across this possible merge, which is to avoid looping and reduce calls to hasEditableStyle() in VisibleUnits.cpp:

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/editing/VisibleUnits.cpp#1121 & https://searchfox.org/wubkat/source/Source/WebCore/editing/VisibleUnits.cpp#1178

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/85355b065acfc6ffbf960afa2d8e175104c556fa

It is just a refactoring to reduce calls, so I think it would be fine to land without any dedicated testcase.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230123/c066646f/attachment.htm>


More information about the webkit-unassigned mailing list