[Webkit-unassigned] [Bug 222366] [WPE][GTK] Move network session APIs to a new WebKitNetworkSession class

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=222366

Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #464577|0                           |1
        is obsolete|                            |

--- Comment #16 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Created attachment 464608

  --> https://bugs.webkit.org/attachment.cgi?id=464608&action=review

WIP patch

Another update.

Done:
 - Enabled and ported cookie manager test.
 - Moved favicon database to WebKitWebsiteDataManager.

Todo:
 - Fix favicon database unit test (it's mostly ported but there are changes in behavior)
 - Add WebKitNetworkSession API test.
 - Port WPE MiniBrowser
 - Port cog

So, in the end I moved the favicons to website data manager, which means ephemeral sessions always load icons when they are enabled. Since it's part of website data manager, there's no api to set the directory, but instead set|get_favicons_enabled. When enabled, the database is created and opened, using the website data manger configuration (base cache directory). Would it make sense to change the default and have favicos enabled by default instead?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230123/f4bb288f/attachment.htm>