[Webkit-unassigned] [Bug 199364] CSS animations in SVG do not repaint when SVG is zoomed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=199364

--- Comment #8 from Ahmad Saleem <ahmad.saleem792 at gmail.com> ---
(In reply to Ahmad Saleem from comment #7)
> (In reply to Ahmad Saleem from comment #6)
> > I tried to fix this bug in following PR:
> > 
> > https://github.com/WebKit/WebKit/pull/4727
> > 
> > by merging following Blink commit:
> > 
> > https://src.chromium.org/viewvc/blink?view=revision&revision=174874
> > 
> > NOTE - Webkit has currently two parallel SVG implementations:
> > 
> > 1) Legacy
> > 2) New Layer Based (LBSE)
> > 
> > Blink patch was modifying code present in LBSE layer (might be common code
> > moved from Legacy to be reused in LBSE).
> > 
> > Based on my discussion with @Said on the PR, it seems that Blink patch is
> > not addressing this CSS animation bug which is kind of repairing / style
> > invalidation issue.
> > 
> > Similarly, Blink commit is also not fixing this case and even the test case
> > with it is not showing any clear expected output to reflect what is being
> > fixed with this patch.
> > 
> > This PR compiles and does not have any failed test case.
> > 
> > Additional note - if I try to take newer code of this test case from Blink /
> > Chromium source, it uses 'rAf' but using updated test script, which
> > leverages some tooling not available in Webkit so we cannot take as is Blink
> > / Chromium latest test case and test in Webkit infrastructure.
> > 
> > Just wanted to document the attempt while I try to investigate in
> > background. Thanks!
> 
> I built local WebKit Release build based of (259195 at main) with and without
> this Blink merge and this blink merge indeed fix the test case mentioned in
> the Comment 0.
> 
> I know Blink patch might be flaky but if everyone is happy for me to fix
> this without test case, I am happy to do PR.

It might be because we also removed "useZoomRules" quirk with this commit on border-width that this patch now works:

https://github.com/WebKit/WebKit/commit/e7f78cb4cd8136f0b3c6e0c02b36009022514452

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230123/d399fe9a/attachment.htm>