[Webkit-unassigned] [Bug 250581] Make MutableStylePropertySet::findPropertyIndex faster

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=250581

--- Comment #3 from Ahmad Saleem <ahmad.saleem792 at gmail.com> ---
(In reply to Ahmad Saleem from comment #2)
> These numbers are from WebKit Trunk (Release - 259178 at main):
> 
> Description: Measures performance of the CSS style getter and setter methods
> (elem.style.(getPropertyValue|removeProperty|setProperty)).
> 
> Time:
> values 14527.112232030273, 14436.09022556391, 14563.843236409608,
> 14508.81612090681, 14454.203262233392, 14545.454545454579,
> 14490.566037735865, 14563.843236409624, 14582.278481012676,
> 14490.566037735849, 14472.361809045226, 14563.843236409608,
> 14545.454545454546, 14563.84323640954, 14527.112232030231,
> 14582.278481012625, 14508.816120906768, 14527.112232030231,
> 14508.816120906835, 14563.843236409675 runs/s
> avg 14526.312733305393 runs/s
> median 14527.112232030253 runs/s
> stdev 42.15659058359132 runs/s
> min 14436.09022556391 runs/s
> max 14582.278481012676 runs/s

I built with same trunk with this patch new build and these are numbers:

Description: Measures performance of the CSS style getter and setter methods (elem.style.(getPropertyValue|removeProperty|setProperty)).

Time:
values 17212.713936430326, 17297.297297297268, 17318.573185731846, 17021.27659574466, 17066.666666666646, 17066.666666666646, 16998.6719787517, 17108.140947752127, 17404.202719406636, 17276.0736196319, 17382.716049382754, 17276.073619631865, 17108.14094775205, 17361.282367447675, 17297.297297297373, 17191.697191697116, 17382.71604938256, 17276.073619631865, 17212.71393643043, 16998.671978751743 runs/s
avg 17212.883333574264 runs/s
median 17244.393778031146 runs/s
stdev 135.20902389383878 runs/s
min 16998.6719787517 runs/s
max 17404.202719406636 runs/s

It is not scientific but it does seem to give some boost. Should I do PR? Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230122/a6948eb8/attachment.htm>