[Webkit-unassigned] [Bug 247795] [git-webkit] git webkit pr should not create a bug for unreviewed commits with no bug associated

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=247795

Jonathan Bedard <jbedard at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WONTFIX

--- Comment #2 from Jonathan Bedard <jbedard at apple.com> ---
We create the bug at branch time, the prompt is:
`Enter issue URL or title of new issue: ` if we have an issue tracker
`Enter name of new branch (or issue URL): ` if we do not.

You can short-circuit the issue creation by providing a branch name instead of issue description (so something like `eng/foobar`) or create the branch before invoking `git-webkit pr`.

The trouble here is that I don't think we want to encourage the practice of commits detached from a bug. It's ok for multiple commits to be attached to a single bug (often, this is even preferable, when talking about something like test gardening or a follow-up fix to an existing commit), but I struggle to think of situation where a commit totally unattached to a bug is acceptable...the only one that comes to mind adding a contributor to contributors.json.

I think the honest answer to this bug is "won't fix", although I can see us making some modification to our prompt to inform the user of the existence of the short-circuit option.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230118/4c6e0a0e/attachment.htm>