[Webkit-unassigned] [Bug 250283] RenderLayer::setHasVisibleContent shouldn't call dirtyZOrderLists()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=250283

--- Comment #3 from Ahmad Saleem <ahmad.saleem792 at gmail.com> ---
Based on PR - (In reply to Ahmad Saleem from comment #2)
> PR - https://github.com/WebKit/WebKit/pull/8695
> 
> Let's try on EWS..

Simon replied that this is something still required in WebKit legacy:

'''

I think we may still need this code in WebKitLegacy. RenderLayer::collectLayers() only collects visibility:hidden layers if includeHiddenLayers is true, and that's only true when compositing is enabled. In WebKitLegacy, we enter compositing mode dynamically.

'''

So I am closing my PR for time being but we can explore it in future when we don't support WebKit Legacy. It passes all tests right now even Mac-wk1 as well but it might have potential to introduce future regressions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230116/342bd5a5/attachment.htm>