[Webkit-unassigned] [Bug 250684] New: [ANGLE] Fix -Wsign-compare warnings on watchOS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=250684

            Bug ID: 250684
           Summary: [ANGLE] Fix -Wsign-compare warnings on watchOS
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: ANGLE
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ddkilzer at webkit.org
                CC: dino at apple.com, kbr at google.com, kkinnunen at apple.com

Fix -Wsign-compare warnings on watchOS.

On watchOS, 'GLintptr' is defined as 'long', so comparing to 'std::numeric_limits<uint32_t>::max()' results in a signed/unsigned comparison:

/Volumes/Data/worker/watchOS-9-Build-EWS/build/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/VertexArrayMtl.mm:1095:57: error: comparison of integers of different signs: 'GLintptr' (aka 'long') and 'std::numeric_limits<unsigned int>::type' (aka 'unsigned int') [-Werror,-Wsign-compare]
    ANGLE_CHECK_GL_MATH(contextMtl, binding.getOffset() <= std::numeric_limits<uint32_t>::max());
                                    ~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /Volumes/Data/worker/watchOS-9-Build-EWS/build/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/VertexArrayMtl.mm:10:
In file included from src/libANGLE/renderer/metal/VertexArrayMtl.h:13:
In file included from src/libANGLE/renderer/VertexArrayImpl.h:12:
src/common/angleutils.h:470:26: note: expanded from macro 'ANGLE_CHECK_GL_MATH'
    ANGLE_CHECK(context, result, "Integer overflow.", GL_INVALID_OPERATION)
                         ^~~~~~
In file included from /Volumes/Data/worker/watchOS-9-Build-EWS/build/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/VertexArrayMtl.mm:10:
In file included from src/libANGLE/renderer/metal/VertexArrayMtl.h:13:
In file included from src/libANGLE/renderer/VertexArrayImpl.h:13:
In file included from src/libANGLE/Buffer.h:16:
In file included from src/libANGLE/Debug.h:16:
src/libANGLE/Error.h:153:30: note: expanded from macro 'ANGLE_CHECK'
        if (ANGLE_UNLIKELY(!(EXPR)))                                                  \
                             ^~~~
In file included from /Volumes/Data/worker/watchOS-9-Build-EWS/build/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/VertexArrayMtl.mm:10:
In file included from src/libANGLE/renderer/metal/VertexArrayMtl.h:13:
In file included from src/libANGLE/renderer/VertexArrayImpl.h:12:
In file included from src/common/angleutils.h:12:
src/common/platform.h:123:55: note: expanded from macro 'ANGLE_UNLIKELY'
#        define ANGLE_UNLIKELY(x) __builtin_expect(!!(x), 0)
                                                      ^

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230116/44476f31/attachment.htm>