[Webkit-unassigned] [Bug 250581] New: Make MutableStylePropertySet::findPropertyIndex faster

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=250581

            Bug ID: 250581
           Summary: Make MutableStylePropertySet::findPropertyIndex faster
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: bfulgham at webkit.org, simon.fraser at apple.com,
                    zalan at apple.com

Hi Team,

While going through Blink's commit, I came across potential performance optimization:

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/501ce3bc186b2bf535ecf3af9f3ce973fe13fd4c

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/css/StyleProperties.cpp#1732

Test Case - https://jsfiddle.net/uek0jp6v/show

____

Safari 16.2:

Time:
values 810.1265822784811, 812.1827411167512, 810.1265822784806, 812.1827411167503, 810.126582278481, 811.1533586818767, 811.1533586818758, 812.1827411167503, 799.0012484394498, 807.0617906683481, 804.0201005025144, 797.0112079701121, 810.1265822784792, 811.1533586818776, 804.0201005025126, 814.2493638676845, 804.0201005025126, 805.0314465408806, 804.0201005025144, 810.1265822784792 runs/s
avg 807.9538335142406 runs/s
median 810.1265822784799 runs/s
stdev 4.694468703933039 runs/s
min 797.0112079701121 runs/s
max 814.2493638676845 runs/s

Safari Technology Preview 161:

Time:
values 818.4143222506392, 821.5661103979442, 825.8064516129027, 821.5661103979476, 820.5128205128215, 818.4143222506403, 823.6808236808256, 824.7422680412391, 821.5661103979461, 819.4622279129302, 824.7422680412352, 819.462227912934, 821.56611039795, 819.4622279129302, 822.6221079691555, 820.5128205128206, 823.6808236808237, 820.5128205128206, 814.2493638676901, 820.5128205128243 runs/s
avg 821.152757938851 runs/s
median 821.0394654553843 runs/s
stdev 2.6746112198361116 runs/s
min 814.2493638676901 runs/s
max 825.8064516129027 runs/s

Chrome Canary 111:

Time:
values 17641.89950290709, 17947.737417819088, 17692.88765597556, 17818.2738536451, 17633.061988601097, 17670.682726693754, 17726.299882436077, 17611.006879299563, 17750.882505529138, 17755.35938936544, 17771.046324581424, 17777.777775101924, 17732.997481108312, 17759.838547990483, 17717.37762837202, 17558.299048133133, 17811.511698768758, 17666.248428976185, 17600, 17597.80027181929 runs/s
avg 17712.04945035617 runs/s
median 17721.83875540405 runs/s
stdev 93.3743887900673 runs/s
min 17558.299048133133 runs/s
max 17947.737417819088 runs/s

Firefox Nightly 110:

Time:
values 11546.39175257732, 11712.418300653595, 11697.127937336814, 11561.290322580646, 11591.203104786546, 11561.290322580646, 11561.290322580646, 11576.227390180879, 11591.203104786546, 11606.21761658031, 11561.290322580646, 11621.271076523995, 11576.227390180879, 11621.271076523995, 11621.271076523995, 11516.709511568124, 11621.271076523995, 11591.203104786546, 11681.877444589309, 11681.877444589309 runs/s
avg 11604.946484951737 runs/s
median 11591.203104786546 runs/s
stdev 53.314369487155936 runs/s
min 11516.709511568124 runs/s
max 11712.418300653595 runs/s

________

Just wanted to raise, so if we can merge 1-1 or if needed then take same idea and apply more optimization.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230113/cb5a1621/attachment-0001.htm>