[Webkit-unassigned] [Bug 250573] [WebKitGTK] REGRESSION(258448 at main): Missing header with libwebrtc (USE_GSTREAMER_WEBRTC=FALSE)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=250573

--- Comment #2 from Manuel A. Fernandez Montecelo <mafm at igalia.com> ---
Created attachment 464486

  --> https://bugs.webkit.org/attachment.cgi?id=464486&action=review

Patch that fixes the issue

I attach a patch that solves the issue.  I was hoping to use something a bit simpler/abstract like using webrtc_INCLUDE_DIRECTORIES but it doesn't seem to work.

The generated file ./WebKitBuild/Release/DerivedSources/WebKit/WebPreferencesDefinitions.h contains the following:
---------
#if ENABLE(WEB_RTC)
#if USE(LIBWEBRTC)
#define DEFAULT_VALUE_FOR_PeerConnectionEnabled WebCore::LibWebRTCProvider::webRTCAvailable()
#elif USE(GSTREAMER_WEBRTC)
#define DEFAULT_VALUE_FOR_PeerConnectionEnabled true
#else
#define DEFAULT_VALUE_FOR_PeerConnectionEnabled false
#endif
#endif
---------

so building this file, when using libwebrtc (instead of the default gstreamer-webrtc) the compiler needs to know about WebCore::LibWebRTCProvider, that's why in commit 9def6e6f0258ddd9171d32bec2fffb684dbc7b8b the line "+#include <WebCore/LibWebRTCProvider.h>" was added to Source/WebKit/UIProcess/WebPreferences.h.

However, when building, WebCore/LibWebRTCProvider.h includes webrtc/api/peer_connection_interface.h and it cannot be found at that point.

(After adding a directory for that, it fails due to missing headers in the abseil-cpp subdir within libwebrtc).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230113/87f7a75d/attachment.htm>