[Webkit-unassigned] [Bug 250524] New: Fix nit which is inefficient sequence to deleteMarkedNodes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 12 13:15:57 PST 2023


            Bug ID: 250524
           Summary: Fix nit which is inefficient sequence to
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Audio
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: cdumez at apple.com

Hi Team,

While going through Blink's commit, I think we can fix inefficient sequence as well:

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/ec81c8eb26580fce076c096c13463d754f40e6c3

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/Modules/webaudio/BaseAudioContext.cpp#179

Move this below:

m_nodesToDelete = std::exchange(m_nodesMarkedForDeletion, { });
---> here

Just wanted to raise so we can fix this.


You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230112/465f1d27/attachment.htm>

More information about the webkit-unassigned mailing list