[Webkit-unassigned] [Bug 250403] New: [GPU Process] DrawFocusRing with timeOffset is not recorded for macOS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=250403

            Bug ID: 250403
           Summary: [GPU Process] DrawFocusRing with timeOffset is not
                    recorded for macOS
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: sabouhallawa at apple.com
                CC: bfulgham at webkit.org, simon.fraser at apple.com,
                    zalan at apple.com

The Recorder::drawFocusRing() versions with timeOffset are not implemented. But after looking at the code, it turned out the timeOffset was never used and we always pass std::numeric_limits<double>::max() to NSInitializeCGFocusRingStyleForTime(). This means the return value of NSInitializeCGFocusRingStyleForTime()() is always false. So we do not need to pass the arguments: timeOffset and needsRepaint to drawFocusRing. Therefore the Mac versions of GraphicsContext::drawFocusRing() are not needed.

So we can have two versions only of GraphicsContext::drawFocusRing():

1. One that takes (const Path&, float outlineWidth, ...). The outlineWidth is used to set the lineWidth on Cairo and to set the blurRadius on Windows.
1. One that takes (const Vector<FloatRect>&, float outlineOffset, float outlineWidth, ...). The outlineOffset is used to shrink the focus ring rectangles. On Cocoa and Windows, this version will convert the rects to a Path and call the previous one.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230110/69276629/attachment.htm>