[Webkit-unassigned] [Bug 250282] New: [Multicolumn] Guard against zero or negative space shortage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=250282

            Bug ID: 250282
           Summary: [Multicolumn] Guard against zero or negative space
                    shortage
           Product: WebKit
           Version: Safari Technology Preview
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: bfulgham at webkit.org, simon.fraser at apple.com,
                    zalan at apple.com

Hi Team,

Just going through Blink's commit, which would be good to add:

Blink Commit: https://src.chromium.org/viewvc/blink?view=revision&revision=174088

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderMultiColumnFlow.cpp#185

Adding following early return (by following WebKit Coding Style - https://webkit.org/code-style-guidelines/#null-false-and-zero):

if (!spaceShortage)
return;

___

Just wanted to raise so this can be fixed for any potential debug issue. I also checked that we never imported these blink test cases etc.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230107/36db9206/attachment-0001.htm>