[Webkit-unassigned] [Bug 250280] New: Simplify computation of text selection top/bottom in Legacy Root Inline

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=250280

            Bug ID: 250280
           Summary: Simplify computation of text selection top/bottom in
                    Legacy Root Inline
           Product: WebKit
           Version: Safari Technology Preview
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: bfulgham at webkit.org, simon.fraser at apple.com,
                    zalan at apple.com

Hi Team,

This is another Blink commit and it is with own merits and issue in terms of text selection but just wanted to raise it for input purposes before doing PR:

Blink Commit - https://chromium.googlesource.com/chromium/src.git/+/e1ac96c0207dd18057fc1f385362b1bee52bb26f

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/rendering/LegacyRootInlineBox.cpp#513 & https://searchfox.org/wubkat/source/Source/WebCore/rendering/LegacyRootInlineBox.cpp#580

One of Test Case - https://jsfiddle.net/p7hged1y/show (from Bug Report) & https://jsfiddle.net/265wb09s/1/show (latter show that the text selection covers part of second line compared to Chrome Canary 111 and Firefox Nightly 110) in Safari 16.2.

Appreciate if someone can share their input whether it is good idea to merge this or not because as per Chrome bug history, it is lesser devil's approach where neither solutions are perfect.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230107/82c04e85/attachment.htm>