[Webkit-unassigned] [Bug 252245] [css-contain-intrinsic-size] auto-011.html is failing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=252245

--- Comment #7 from cathiechen <cathiechen at igalia.com> ---
Comment on attachment 465135
  --> https://bugs.webkit.org/attachment.cgi?id=465135
WIP-patch

View in context: https://bugs.webkit.org/attachment.cgi?id=465135&action=review

>> Source/WebCore/rendering/GridTrackSizingAlgorithm.h:290
>> +    bool isComputingSizeOrInlineSizeContainment() { return isComputingSizeContainment() || isComputingInlineSizeContainment(); }
> 
> Nit: probably not that important in practice, but making it virtual and then in IndefiniteSizeStrategy
> 
> bool isComputingSizeOrInlineSizeContainment() const override { return renderGrid()->shouldApplySizeOrInlineSizeContainment(); }
> 
> would ensure a single shouldApplySizeOrStyleContainment().

Done, thanks:)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230228/138cac63/attachment-0001.htm>