[Webkit-unassigned] [Bug 252245] [css-contain-intrinsic-size] auto-011.html is failing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 23 09:00:21 PST 2023


https://bugs.webkit.org/show_bug.cgi?id=252245

--- Comment #6 from Oriol Brufau <obrufau at igalia.com> ---
Comment on attachment 465135
  --> https://bugs.webkit.org/attachment.cgi?id=465135
WIP-patch

View in context: https://bugs.webkit.org/attachment.cgi?id=465135&action=review

> Source/WebCore/rendering/GridTrackSizingAlgorithm.h:290
> +    bool isComputingSizeOrInlineSizeContainment() { return isComputingSizeContainment() || isComputingInlineSizeContainment(); }

Nit: probably not that important in practice, but making it virtual and then in IndefiniteSizeStrategy

bool isComputingSizeOrInlineSizeContainment() const override { return renderGrid()->shouldApplySizeOrInlineSizeContainment(); }

would ensure a single shouldApplySizeOrStyleContainment().

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230223/315e3134/attachment.htm>


More information about the webkit-unassigned mailing list