[Webkit-unassigned] [Bug 252245] [css-contain-intrinsic-size] auto-011.html is failing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=252245

--- Comment #4 from cathiechen <cathiechen at igalia.com> ---
Comment on attachment 464983
  --> https://bugs.webkit.org/attachment.cgi?id=464983
WIP-patch

View in context: https://bugs.webkit.org/attachment.cgi?id=464983&action=review

Thanks for the review, Oriol!

>> Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:798
>> +    if (m_direction == ForColumns && (m_strategy->isComputingSizeContainment() || m_strategy->isComputingInlineSizeContainment())) {
> 
> May be good to add GridTrackSizingAlgorithmStrategy::isComputingSizeOrInlineSizeContainment()

Done!

>> Source/WebCore/rendering/RenderBox.cpp:5604
>> +    ASSERT(shouldApplySizeContainment() || (isHorizontalWritingMode() && shouldApplyInlineSizeContainment()));
> 
> Nit: shouldApplySizeContainment() and shouldApplyInlineSizeContainment() have some common logic that might run twice, so this seems better:
> 
> isHorizontalWritingMode() ? shouldApplySizeOrInlineSizeContainment() : shouldApplySizeContainment()

Done

>> Source/WebCore/rendering/RenderBox.cpp:5620
>> +    ASSERT(shouldApplySizeContainment() || (!isHorizontalWritingMode() && shouldApplyInlineSizeContainment()));
> 
> Nit: isHorizontalWritingMode() ? shouldApplySizeContainment() : shouldApplySizeOrInlineSizeContainment()

Done

>> Source/WebCore/rendering/RenderGrid.cpp:678
>> +    return shouldApplySizeContainment();
> 
> Nit: return direction == ForColumns ? shouldApplySizeOrInlineSizeContainment() : shouldApplySizeContainment();

Done:)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230223/9ca72f45/attachment.htm>