[Webkit-unassigned] [Bug 252245] [css-contain-intrinsic-size] auto-011.html is failing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=252245

Oriol Brufau <obrufau at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |obrufau at igalia.com

--- Comment #3 from Oriol Brufau <obrufau at igalia.com> ---
Comment on attachment 464983
  --> https://bugs.webkit.org/attachment.cgi?id=464983
WIP-patch

View in context: https://bugs.webkit.org/attachment.cgi?id=464983&action=review

> Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:798
> +    if (m_direction == ForColumns && (m_strategy->isComputingSizeContainment() || m_strategy->isComputingInlineSizeContainment())) {

May be good to add GridTrackSizingAlgorithmStrategy::isComputingSizeOrInlineSizeContainment()

> Source/WebCore/rendering/RenderBox.cpp:5604
> +    ASSERT(shouldApplySizeContainment() || (isHorizontalWritingMode() && shouldApplyInlineSizeContainment()));

Nit: shouldApplySizeContainment() and shouldApplyInlineSizeContainment() have some common logic that might run twice, so this seems better:

isHorizontalWritingMode() ? shouldApplySizeOrInlineSizeContainment() : shouldApplySizeContainment()

> Source/WebCore/rendering/RenderBox.cpp:5620
> +    ASSERT(shouldApplySizeContainment() || (!isHorizontalWritingMode() && shouldApplyInlineSizeContainment()));

Nit: isHorizontalWritingMode() ? shouldApplySizeContainment() : shouldApplySizeOrInlineSizeContainment()

> Source/WebCore/rendering/RenderGrid.cpp:678
> +    if (direction == ForColumns && shouldApplyInlineSizeContainment())
> +        return true;
> +
> +    return shouldApplySizeContainment();

Nit: return direction == ForColumns ? shouldApplySizeOrInlineSizeContainment() : shouldApplySizeContainment();

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230222/cb37cc39/attachment-0001.htm>