[Webkit-unassigned] [Bug 252720] New: [GTK][WPE] Mismatch between the WebKit version recorded on the MiniBrowser on the build products that are generated on the nightly bots

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=252720

            Bug ID: 252720
           Summary: [GTK][WPE] Mismatch between the WebKit version
                    recorded on the MiniBrowser on the build products that
                    are generated on the nightly bots
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKitGTK
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: clopez at igalia.com
                CC: bugs-noreply at webkitgtk.org

The GTK and WPE nightly bots at https://build.webkit.org/#/builders/30 and https://build.webkit.org/#/builders/2 run once per day generating a build-product for Ubuntu 20.04

Those products are uploaded to https://webkitgtk.org/built-products/x86_64/release/nightly/Ubuntu-20.04/MiniBrowser/ and https://wpewebkit.org/built-products/x86_64/release/nightly/Ubuntu-20.04/MiniBrowser/


The issue is that when you download one of those build-products and you execute "MiniBrowser --version" the version it outputs is from more than 6 months ago.


Check: http://sprunge.us/CIKgiW
   - Version MiniBrowser_gtk_260526 at main.zip is downloaded but when running `MiniBrowser --version` it outputs 252782 at main


Digging into this the problem is caused by how the script Tools/glib/apply-build-revision-to-files.py obtains the current version of WebKit.
It uses origin/HEAD instead of HEAD and that causes a mistmatch with how the buildbot updates the git repository on the bots.

See how buildbot updates the git repository: https://build.webkit.org/#/builders/30/builds/8422/steps/3/logs/stdio

It basically does:

git fetch -f - https://github.com/WebKit/WebKit.git HEAD --progress
git reset --hard FETCH_HEAD --

instead of doing "git pull" or similar.

So on the bot GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004 is currently happening this on the build checkout

buildbot at bb-webkit-packaging-ubuntu2004-64:~/webkitgtk/nightly/GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004/build$ git status
On branch main
Your branch is ahead of 'origin/main' by 7808 commits.
  (use "git push" to publish your local commits)

nothing to commit, working tree clean

buildbot at bb-webkit-packaging-ubuntu2004-64:~/webkitgtk/nightly/GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004/build$ git describe HEAD
webkitgtk-2.39.7-966-gf07b7ad2599f
buildbot at bb-webkit-packaging-ubuntu2004-64:~/webkitgtk/nightly/GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004/build$ git describe FETCH_HEAD
webkitgtk-2.39.7-966-gf07b7ad2599f
buildbot at bb-webkit-packaging-ubuntu2004-64:~/webkitgtk/nightly/GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004/build$ git describe origin/HEAD
webkitgtk-2.37.1-406-g7a065485d2f1
buildbot at bb-webkit-packaging-ubuntu2004-64:~/webkitgtk/nightly/GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004/build$ git log -1 --pretty="%H %cD" HEAD
f07b7ad2599f5c00c5e5464508485e879930364d Mon, 20 Feb 2023 21:35:36 -0800
buildbot at bb-webkit-packaging-ubuntu2004-64:~/webkitgtk/nightly/GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004/build$ git log -1 --pretty="%H %cD" FETCH_HEAD
f07b7ad2599f5c00c5e5464508485e879930364d Mon, 20 Feb 2023 21:35:36 -0800
buildbot at bb-webkit-packaging-ubuntu2004-64:~/webkitgtk/nightly/GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004/build$ git log -1 --pretty="%H %cD" origin/HEAD
7a065485d2f19a25311e51a57b78a5210e3518f4 Mon, 25 Jul 2022 04:45:50 -0700

As you see origin/HEAD doesn't match the current HEAD checkout (is off by more than 6 months) because of the way the bot updates the git repo

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230222/e2ce5f58/attachment.htm>