[Webkit-unassigned] [Bug 252666] Fix JPEGImageDecoder boolean enum and #define TRUE/FALSE mix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 21 08:08:03 PST 2023


https://bugs.webkit.org/show_bug.cgi?id=252666

Giulio Benetti <giulio.benetti at benettiengineering.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #465108|0                           |1
        is obsolete|                            |

--- Comment #1 from Giulio Benetti <giulio.benetti at benettiengineering.com> ---
Created attachment 465109

  --> https://bugs.webkit.org/attachment.cgi?id=465109&action=review

Fix JPEGImageDecoder boolean enum and #define TRUE/FALSE mix

Fix JPEGImageDecoder boolean enum and #define TRUE/FALSE mix
https://bugs.webkit.org/show_bug.cgi?id=252666

Reviewed by NOBODY (OOPS!).

jpeglib.h contains a typedef enum for boolean type but LCMSUniquePtr.h
include files that can contain #define TRUE/FALSE. This way build fails
with:
JPEGImageDecoder.cpp:343:43: error: invalid conversion from ‘int’ to ‘boolean’

This is because TRUE or FALSE should be an enum instead they get defined
as 1 or 0. To fix this move jpeglib.h inclusion after LCMSUniquePtr.h
inclusion.

Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.h:

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230221/f22795bf/attachment.htm>


More information about the webkit-unassigned mailing list