[Webkit-unassigned] [Bug 251544] AX: input[type=date] individual fields are announced as "group"

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=251544

--- Comment #5 from Chris <chris.gilardi+webkit at vidaloop.com> ---
(In reply to Tyler Wilcock from comment #4)
> (In reply to Chris from comment #3)
> > Hi Tyler, thanks for your response! Would you happen to potentially have an
> > already-implemented example of this idea somewhere else in the project?
> > 
> > I was able to find the pseudo-elements and where they are created but can't
> > really get my head around how I would programmatically add the `aria-label`
> > attribute. Is there any example of this you can think of that I could look
> > at?
> > 
> > If not, I can keep looking and I'm sure I'll figure it out eventually :)
> Hey again Chris. One example you could reference is here where we add an
> aria-label for a user-agent controlled autofill button element:
> 
> https://github.com/WebKit/WebKit/blob/
> f0420f3bf5b9316e4871996ebda2a1cc0191096a/Source/WebCore/html/
> TextFieldInputType.cpp#L872
> 
> In general, you can find where any attribute is used in WebKit by searching
> for:
> 
>   * "fooAttr" for single-word attributes
>   * "foo_barAttr" for multi-word attributes (where the words are separated
> by hyphen)

Hey again Tyler, really sorry to ping again about this.

I have been able to find and update the attributes as you suggested, however, I cannot for the life of me get changes to reflect when running my build with `Tools/Scripts/run-safari`.

I've searched around for fixes to this but haven't really figured out what's wrong. I'm assuming it's some kind of build cache but I can't seem to get it to work.

Here's how I'm testing it (note: my test here is NOT on the date input because i wanted to edit a value I could check more easily):

1. I'm updating line 324 in (Source/WebCore/html/shadow/TextControlInnerElements.cpp)

to `element->setAttributeWithoutSynchronization(roleAttr, HTMLNames::inputTag->localName());`

(I am updating this instance just because it's a little easier for me to reliably test. Once I get it changing here I will be able to more reliably test my changes to the date input).

2. I run `Tools/Scripts/build-webkit --debug`
2a. The build succeeds with: "** BUILD SUCCEEDED ** [1571.372 sec]"

3. I run `Tools/Scripts/run-safari --debug`.
4. I go to this url: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/search
4a. I enter some text in the "Search the site" box so the X button comes up
4b. Using the Accessibility Inspector, I check that X button. Its role should be "input" but it still shows as "button"

Any ideas about how to get these changes to reflect? Again, I apologize if this is just my lack of knowledge of the project/build tooling.

Thanks again for your time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230217/c866ae90/attachment.htm>