[Webkit-unassigned] [Bug 252308] REGRESSION(256816 at main): [CMake] Build not reproducible due to __TIMESTAMP__ macro in generated file

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=252308

Michael Catanzaro <mcatanzaro at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcatanzaro at gnome.org
          Component|WebKitGTK                   |JavaScriptCore
            Summary|[GTK] [2.39.7] Build not    |REGRESSION(256816 at main):
                   |reproducible due to         |[CMake] Build not
                   |__TIMESTAMP__ macro in      |reproducible due to
                   |generated file              |__TIMESTAMP__ macro in
                   |                            |generated file

--- Comment #1 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Indeed, __TIMESTAMP__ is only deterministic when the source file is not generated, because it's based on last modification of the source file. The new comment in JSCBytecodeCacheVersion.h is also wrong except on Apple ports.

The solution here should be to do the same thing Apple does: cat JSCBuiltins.o with CachedTypes.o and then hash that. They also use build version, but I'm not sure why and that can probably be ignored. This would likely be a good newcomers bug as it can be done entirely from CMake with no need to touch the source code files.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230215/9f6a145a/attachment.htm>