[Webkit-unassigned] [Bug 252064] New: Fix mistakes in WebKitTargetConditionals.xcconfig

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=252064

            Bug ID: 252064
           Summary: Fix mistakes in WebKitTargetConditionals.xcconfig
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ddkilzer at webkit.org

Fix mistakes in WebKitTargetConditionals.xcconfig.

The following macros are defined incorrectly (they result in circular definitions):

```
WK_IOS_17 = $(WK_IOS_17_$(WK_IOS_BEFORE_17));
WK_IOS_17_ = $(WK_IOS_17);  // BUG: Circular definition.
[...]
WK_TVOS_16 = $(WK_TVOS_16_$(WK_TVOS_BEFORE_16));
WK_TVOS_16_ = $(WK_TVOS_16);  // BUG: Circular definition.
[...]
WK_TVOS_17 = $(WK_TVOS_17_$(WK_TVOS_BEFORE_17));
WK_TVOS_17_ = $(WK_TVOS_17);  // BUG: Circular definition.
```

The net effect of this error was that Bug 245692 had no effect on iOS builds because `WK_IOS_17` would never be defined as `_IOS_SINCE_17`:

    Enable libc++ assertions
    https://bugs.webkit.org/show_bug.cgi?id=245692
    rdar://100416021
    https://commits.webkit.org/259122@main

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230210/07e7139f/attachment-0001.htm>