[Webkit-unassigned] [Bug 252046] New: Avoid the unnecessary setting of min-width 0 on RenderButton & RenderMenuList

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 10 04:15:56 PST 2023


https://bugs.webkit.org/show_bug.cgi?id=252046

            Bug ID: 252046
           Summary: Avoid the unnecessary setting of min-width 0 on
                    RenderButton & RenderMenuList
           Product: WebKit
           Version: Safari Technology Preview
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: bfulgham at webkit.org, simon.fraser at apple.com,
                    zalan at apple.com

Hi Team,

While going through Blink's commit, I came across this clean-up commit:

Commit - https://chromium.googlesource.com/chromium/blink/+/930980f79f4061b999ba474313b456563c878197

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderButton.cpp#77 & https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderMenuList.cpp#118

I compiled it locally and also tested this WPT:http://wpt.live/css/css-sizing/button-min-width.html , it still passed.

Just wanted to raise get input whether this clean-up is something worth doing.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230210/050158c4/attachment.htm>


More information about the webkit-unassigned mailing list