[Webkit-unassigned] [Bug 251919] New: Page Serializer: Specify encoding for serialized CSS files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=251919

            Bug ID: 251919
           Summary: Page Serializer: Specify encoding for serialized CSS
                    files
           Product: WebKit
           Version: Safari Technology Preview
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: New Bugs
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com

Hi Team,

Wile going through Blink's commit, I came across another potential one but I am not sure, whether it will have an impact since we don't have MHTML but we seems have to have FIXME:

Blink Commit - https://chromium.googlesource.com/chromium/src.git/+/f7030ffe17ea03cf8a2e9189d7d764dfd07da26a

WebKit Source FIXME - https://searchfox.org/wubkat/source/Source/WebCore/page/PageSerializer.cpp#267

We don't have appendLiteral, so following needs to be added after Line 242:

cssText.append("@charset \"");
cssText.append(styleSheet->contents().charset().convertToASCIILowercase());
cssText.append("\";\n\n");

___

Don't know equivalent of lower() from blink commit but I think it would be 'convertToASCIILowercase()'.

Just wanted to raise a get input whether to merge it or get rid of "FIXME". Don't have testcase as well. :-(

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230208/9aee5b45/attachment.htm>