[Webkit-unassigned] [Bug 251914] New: BuilderConverter::convertLineHeight() should not return an std::optional<Length>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=251914

            Bug ID: 251914
           Summary: BuilderConverter::convertLineHeight() should not
                    return an std::optional<Length>
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: CSS
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: graouts at webkit.org

There is this comment at the end of BuilderConverter::convertLineHeight():

    // FIXME: The parser should only emit the above types, so this should never be reached. We should change the
    // type of this function to return just a Length (and not an Optional).
    return std::nullopt;

Let's fix this!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230208/62b4255b/attachment.htm>