[Webkit-unassigned] [Bug 251904] New: EffectiveLang optimization fails when document element is replaced

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=251904

            Bug ID: 251904
           Summary: EffectiveLang optimization fails when document element
                    is replaced
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: DOM
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: heycam at apple.com

If the document element has a lang attribute and it is removed from its parent document node, we can hit the assertion in Element::updateEffectiveLangStateFromParent that checks we don't have a lang attribute.  This is because Element::removedFromAncestor checks that the element doesn't have effective lang state before calling updateEffectiveLangStateFromParent(), with the understanding that "no effective lang state" means the element is in the common case of inheriting the document element lang state directly, i.e. there's no intervening ancestor with a lang attribute at all.

Additionally, we don't correctly handle updating the document element language when the document element is removed or replaced.  (We only update the document element language when the lang attribute on a current document element is changed.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230208/97544874/attachment-0001.htm>