[Webkit-unassigned] [Bug 229909] -webkit-image-set() should be an alias of image-set()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 6 15:04:17 PST 2023


Ryan Reno <rreno at apple.com> changed:

           What    |Removed                     |Added
                 CC|                            |rreno at apple.com

--- Comment #8 from Ryan Reno <rreno at apple.com> ---
I can't reproduce the gmail issue with this simple diff:

diff --git a/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp b/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
index 173d2397e7c4..5c836404e9ba 100644
--- a/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
+++ b/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
@@ -4672,10 +4672,8 @@ RefPtr<CSSValue> consumeImage(CSSParserTokenRange& range, const CSSParserContext
             return consumeGeneratedImage(range, context);

         if (allowedImageTypes.contains(AllowedImageType::ImageSet)) {
-            if (functionId == CSSValueImageSet)
+            if (functionId == CSSValueImageSet || functionId == CSSValueWebkitImageSet)
                 return consumeImageSet(range, context, (allowedImageTypes | AllowedImageType::RawStringAsURL) - AllowedImageType::ImageSet);
-            if (functionId == CSSValueWebkitImageSet)
-                return consumeImageSet(range, context, AllowedImageType::URLFunction);

But that diff does progress some of the WPT subtests we are currently failing because we don't implement -webkit-image-set as an alias.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230206/1d2c072b/attachment-0001.htm>

More information about the webkit-unassigned mailing list