[Webkit-unassigned] [Bug 251091] Distorted audio after getUserMedia when playing with AudioWorkletNode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=251091

Chris Dumez <cdumez at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |235317

--- Comment #6 from Chris Dumez <cdumez at apple.com> ---
(In reply to Chris Dumez from comment #5)
> It is because of this logic:
> ```
> void RemoteAudioSessionProxyManager::updatePreferredBufferSizeForProcess()
> {
> #if ENABLE(MEDIA_STREAM)
>     if
> (CoreAudioCaptureSourceFactory::singleton().isAudioCaptureUnitRunning()) {
>        
> CoreAudioCaptureSourceFactory::singleton().
> whenAudioCaptureUnitIsNotRunning([weakThis = WeakPtr { *this }] {
>             if (weakThis)
>                 weakThis->updatePreferredBufferSizeForProcess();
>         });
>         return;
>     }
> #endif
>    // ...
> ```
> 
> If we're capturing (which we are here since we called getUserMedia), then we
> defer the setting of the preferred buffer size (128) until we're done
> capturing. Since capturing is ongoing, we just keep using 960, which breaks
> Web Audio.

This is a regression from Youenn's Bug 235317.


Referenced Bugs:

https://bugs.webkit.org/show_bug.cgi?id=235317
[Bug 235317] [Cocoa] Do not change preferred AudioSession buffer size when VPIO is running
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230206/85910e5b/attachment-0001.htm>