[Webkit-unassigned] [Bug 251700] New: DisplayList::ItemBuffer wastes a lot of vector capacity

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 3 10:29:01 PST 2023


https://bugs.webkit.org/show_bug.cgi?id=251700

            Bug ID: 251700
           Summary: DisplayList::ItemBuffer wastes a lot of vector
                    capacity
           Product: WebKit
           Version: WebKit Local Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: simon.fraser at apple.com
                CC: bfulgham at webkit.org, simon.fraser at apple.com,
                    zalan at apple.com

Using the patch in bug 186698, and testing on a wikipedia page, we see that DisplayList::ItemBuffer::ItemBuffer() wastes a lot of vector capacity:

Wasted capacity: 31632 bytes (used 0 of 31632 bytes, utilization: 0.00%) - 659 allocations
1   0x2fd3346e7 WTF::VectorBuffer<WebCore::DisplayList::ItemBufferHandle, 2ul, WTF::FastMalloc>::VectorBuffer()
2   0x2fd3313d1 WebCore::DisplayList::ItemBuffer::ItemBuffer()
3   0x2fd33119c WebCore::DisplayList::DisplayList::itemBuffer()
4   0x2fd3311fe WebCore::DisplayList::DisplayList::setItemBufferWritingClient(WebCore::DisplayList::ItemBufferWritingClient*)
5   0x2fd336a1b WebCore::DisplayList::InMemoryDisplayList::InMemoryDisplayList()
6   0x2fd30735a WebCore::FontCascade::displayListForTextRun(WebCore::GraphicsContext&, WebCore::TextRun const&, unsigned int, std::__1::optional<unsigned int>, WebCore::FontCascade::CustomFontNotReadyAction) const
7   0x2fcc5efd4 WebCore::GlyphDisplayListCache::get(void const*, WebCore::FontCascade const&, WebCore::GraphicsContext&, WebCore::TextRun const&)
8   0x2fcdf55a2 WebCore::TextBoxPainter<WebCore::InlineIterator::BoxModernPath>::paintForeground(WebCore::StyledMarkedText const&)
9   0x2fcdf3efe WebCore::TextBoxPainter<WebCore::InlineIterator::BoxModernPath>::paintForegroundAndDecorations()
10  0x2fcdf3656 WebCore::TextBoxPainter<WebCore::InlineIterator::BoxModernPath>::paint()
11  0x2fc7e0b49 WebCore::LayoutIntegration::InlineContentPainter::paintDisplayBox(WebCore::InlineDisplay::Box const&)
12  0x2fc7e0db5 WebCore::LayoutIntegration::InlineContentPainter::paint()
13  0x2fc7e54a8 WebCore::LayoutIntegration::LineLayout::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&, WebCore::RenderInline const*)
14  0x2fcc96d0e WebCore::RenderBlock::paintObject(WebCore::PaintInfo&, WebCore::LayoutPoint const&)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230203/35b6dba9/attachment.htm>


More information about the webkit-unassigned mailing list