[Webkit-unassigned] [Bug 214870] [WPE][Pointer Events] Add support for touch based pointer events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=214870

Bastian Krause <bst at pengutronix.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bst at pengutronix.de

--- Comment #8 from Bastian Krause <bst at pengutronix.de> ---
Comment on attachment 405352
  --> https://bugs.webkit.org/attachment.cgi?id=405352
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405352&action=review

>> Source/WebCore/page/EventHandler.cpp:4094
>> +        // TouchStationary state is not converted to touch events, so fall through to assert.
> 
> I couldn't easily follow the logic below in EventHandler::handleTouchEvent, but it didn't immediately look like a TouchStationary event wouldn't be passed to this function - could you explain how this gets handled so that this ought to never happen?

AFAICS this follows the same logic as eventNameForTouchPointState() does, which follows the same assumption. handleTouchPointerEvent() also contains the same note about TouchStationary, so I think this applies here as well.

>> Source/WebCore/page/PointerCaptureController.cpp:193
>> +static Ref<PointerEvent> createPointerEvent(const String& type, const PlatformTouchEvent& platformTouchEvent, unsigned index, bool isPrimary, WindowProxy& view, const Touch* touch)
> 
> I think it would make for a slightly cleaner look elsewhere to reorder these so that the unused-on-WPE parameters come last and have defaults so that they can be ommitted when calling this function.

I can't see the advantage here, this is a static function that is called from platform-unspecific code, so where would these defaults help exactly?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230203/93718f5c/attachment.htm>