[Webkit-unassigned] [Bug 251691] New: Use `isControlCharacter()` helper

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 3 08:18:44 PST 2023


https://bugs.webkit.org/show_bug.cgi?id=251691

            Bug ID: 251691
           Summary: Use `isControlCharacter()` helper
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Text
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: vitaly at igalia.com
                CC: mmaxfield at apple.com

Several ways to check whether a character is a Unicode control character are used throughout the codebase. Such as:
```
u_charType(character) == U_CONTROL_CHAR
```
or
```
(character >= nullCharacter && character < space) || (character >= deleteCharacter && character < noBreakSpace)
```
We have a nice helper for this in `CharacterProperties.h` - `isControlCharacter()`.
It would be nice to use it since it is shorter and describes the intent better.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230203/e44c6f7f/attachment.htm>


More information about the webkit-unassigned mailing list