[Webkit-unassigned] [Bug 266954] New: Only use SVG Elements for SVG animation events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=266954

            Bug ID: 266954
           Summary: Only use SVG Elements for SVG animation events
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: SVG
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: heycam at apple.com, rbuis at igalia.com,
                    sabouhallawa at apple.com, simon.fraser at apple.com,
                    zimmermann at kde.org

Hi Team,

While looking into Blink commit and matching with WebKit's, I noticed that we can merge following:

Blink Commit: https://chromium.googlesource.com/chromium/blink/+/111ccefde5e2f747b600500b71e6737533bc5241

WebKit Source: https://searchfox.org/wubkat/rev/af9971e796398c1d012ef5df9a09ed580d19bd17/Source/WebCore/svg/animation/SVGSMILElement.cpp#562

We have 'Element' here, while we should restrict it to 'SVGElement'. We don't have to merge and do all changes, following compiles:

In 'SVGSMILElement.cpp':

inline RefPtr<SVGElement> SVGSMILElement::eventBaseFor(const Condition& condition)
{
    RefPtr eventBase = condition.m_baseID.isEmpty() ? RefPtr<Element> { targetElement() } : treeScope().getElementById(condition.m_baseID);
    if (eventBase && eventBase->isSVGElement())
        return downcast<SVGElement>(eventBase);
    return nullptr;
}

and

equivalent in SVGSMILElement.h:

    RefPtr<SVGElement> eventBaseFor(const Condition&);

___

Just wanted to raise to get input.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240101/7042031c/attachment-0001.htm>