[Webkit-unassigned] [Bug 266906] New: Remove unused 'HTMLSelectElement::deselectItems' function

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 26 17:16:27 PST 2023


https://bugs.webkit.org/show_bug.cgi?id=266906

            Bug ID: 266906
           Summary: Remove unused 'HTMLSelectElement::deselectItems'
                    function
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Forms
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: cdumez at apple.com, wenson_hsieh at apple.com

Hi Team,

While looking into HTMLSelectElement code, it seems that 'deselectItems' code is just referring to another function and there are no call-sites while looking into 'searchfox.org' (wubkat).

I think we can safely remove this and make code bit cleaner.

WebKit Source: https://github.com/WebKit/WebKit/blob/f9465ea35d9a2969110e5955b30d8c11bc699c91/Source/WebCore/html/HTMLSelectElement.cpp#L118

https://github.com/WebKit/WebKit/blob/f9465ea35d9a2969110e5955b30d8c11bc699c91/Source/WebCore/html/HTMLSelectElement.h#L159

Just wanted to raise so we can try PR and see if it leads to any regression etc.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20231227/e0354945/attachment-0001.htm>


More information about the webkit-unassigned mailing list