[Webkit-unassigned] [Bug 266879] New: Make "Outdent" command to respect CSS display property

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=266879

            Bug ID: 266879
           Summary: Make "Outdent" command to respect CSS display property
           Product: WebKit
           Version: Safari Technology Preview
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: HTML Editing
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: wenson_hsieh at apple.com

Hi Team,

While going through Blink's commit, I came across following commit, which I think can be merged:

Blink Commit: https://chromium.googlesource.com/chromium/src.git/+/73a2d635d5779e1092de3d26e4ee33d758d46444

WebKit Commit: https://github.com/WebKit/WebKit/blob/b2da34277e48164f292542ed493e1c4177fba7ce/Source/WebCore/editing/IndentOutdentCommand.cpp#L47

Below compiles and don't regress anything in 'WPT' (selection / editing etc.):

// Returns true if `node` is UL, OL, or BLOCKQUOTE with "display:block".
// "Outdent" command considers <BLOCKQUOTE style="display:inline"> makes
// indentation.
static bool isListOrIndentBlockquote(const Node& node)
{
    const auto& element = dynamicDowncast<HTMLElement>(node);
    if (!element)
        return false;
    if (!node.renderer() || !node.renderer()->isRenderBlock())
        return false;
    return node.hasTagName(ulTag) || node.hasTagName(olTag) || node.hasTagName(blockquoteTag);
}

____

Just wanted to raise to get input, if we can fix it.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20231225/a0a2b8c9/attachment.htm>