[Webkit-unassigned] [Bug 266849] New: 2.43.3 fails to build with USE_SYSTEMD=OFF and ENABLE_JOURNALD_LOG=OFF

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=266849

            Bug ID: 266849
           Summary: 2.43.3 fails to build with USE_SYSTEMD=OFF and
                    ENABLE_JOURNALD_LOG=OFF
           Product: WebKit
           Version: WebKit Local Build
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: CMake
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: balducci at units.it

hello

build of 2.43.3 on gnu-linux/X86_64/gcc-13.2.0 with:

----8<----
-DUSE_SYSTEMD=OFF
-DENABLE_JOURNALD_LOG=OFF
---->8----

is apparently broken (complete list of used options is attached at the end)

I get a first stop with:

----8<----
/usr/bin/g++  -DBUILDING_GTK__=1 -DBUILDING_WEBKIT=1 -DBUILDING_WITH_CMAKE=1 -DBUILDING_WebCore [huge g++ input omitted] -c /home/balducci/tmp/install-us-d/webkitgtk-2.43.3/webkitgtk-2.43.3/.build/WebCore/DerivedSources/unified-sources/UnifiedSource-3a52ce78-85.cpp
In file included from /home/balducci/tmp/install-us-d/webkitgtk-2.43.3/webkitgtk-2.43.3/.build/WebCore/DerivedSources/JSImageCapture.h:25,
                 from /home/balducci/tmp/install-us-d/webkitgtk-2.43.3/webkitgtk-2.43.3/.build/WebCore/DerivedSources/JSImageCapture.cpp:25,
                 from /home/balducci/tmp/install-us-d/webkitgtk-2.43.3/webkitgtk-2.43.3/.build/WebCore/DerivedSources/unified-sources/UnifiedSource-3a52ce78-85.cpp:6:
/home/balducci/tmp/install-us-d/webkitgtk-2.43.3/webkitgtk-2.43.3/Source/WebCore/Modules/mediastream/ImageCapture.h: In member function ‘const WTF::Logger& WebCore::ImageCapture::logger() const’:
/home/balducci/tmp/install-us-d/webkitgtk-2.43.3/webkitgtk-2.43.3/Source/WebCore/Modules/mediastream/ImageCapture.h:60:43: error: ‘m_logger’ was not declared in this scope; did you mean ‘logger’?
   60 |     const Logger& logger() const { return m_logger.get(); }
      |                                           ^~~~~~~~
      |                                           logger
/home/balducci/tmp/install-us-d/webkitgtk-2.43.3/webkitgtk-2.43.3/Source/WebCore/Modules/mediastream/ImageCapture.h: In member function ‘const void* WebCore::ImageCapture::logIdentifier() const’:
/home/balducci/tmp/install-us-d/webkitgtk-2.43.3/webkitgtk-2.43.3/Source/WebCore/Modules/mediastream/ImageCapture.h:61:48: error: ‘m_logIdentifier’ was not declared in this scope; did you mean ‘logIdentifier’?
   61 |     const void* logIdentifier() const { return m_logIdentifier; }
      |                                                ^~~~~~~~~~~~~~~
      |                                                logIdentifier
---->8----

I can work around with:

----8<----
#> diff ImageCapture.h.ORIG_2023-12-22_142241 ImageCapture.h
69c69
< #if !RELEASE_LOG_DISABLED
---
> // #if !RELEASE_LOG_DISABLED
72c72
< #endif
---
> // #endif
---->8----

But then I get:

----8<----
/usr/bin/g++  -DBUILDING_GTK__=1 -DBUILDING_WEBKIT=1 -DBUILDING_WITH_CMAKE=1 -DBUILDING_WebCore [huge g++ input omitted] -c /home/balducci/tmp/install-us-d/webkitgtk-2.43.3/webkitgtk-2.43.3/.build/WebCore/DerivedSources/unified-sources/UnifiedSource-f8afad56-26.cpp
In file included from /home/balducci/tmp/install-us-d/webkitgtk-2.43.3/webkitgtk-2.43.3/.build/WebCore/DerivedSources/unified-sources/UnifiedSource-f8afad56-26.cpp:6:
/home/balducci/tmp/install-us-d/webkitgtk-2.43.3/webkitgtk-2.43.3/Source/WebCore/Modules/mediastream/ImageCapture.cpp: In constructor ‘WebCore::ImageCapture::ImageCapture(WebCore::Document&, WTF::Ref<WebCore::MediaStreamTrack>)’:
/home/balducci/tmp/install-us-d/webkitgtk-2.43.3/webkitgtk-2.43.3/Source/WebCore/Modules/mediastream/ImageCapture.cpp:57:23: error: ‘class WebCore::MediaStreamTrack’ has no member named ‘logger’
   57 |     , m_logger(track->logger())
      |                       ^~~~~~
/home/balducci/tmp/install-us-d/webkitgtk-2.43.3/webkitgtk-2.43.3/Source/WebCore/Modules/mediastream/ImageCapture.cpp:58:30: error: ‘class WebCore::MediaStreamTrack’ has no member named ‘logIdentifier’
   58 |     , m_logIdentifier(track->logIdentifier())
      |                              ^~~~~~~~~~~~~
/home/balducci/tmp/install-us-d/webkitgtk-2.43.3/webkitgtk-2.43.3/Source/WebCore/Modules/mediastream/ImageCapture.cpp: In member function ‘WTFLogChannel& WebCore::ImageCapture::logChannel() const’:
/home/balducci/tmp/install-us-d/webkitgtk-2.43.3/webkitgtk-2.43.3/Source/WebCore/Modules/mediastream/ImageCapture.cpp:129:12: error: ‘LogWebRTC’ was not declared in this scope
  129 |     return LogWebRTC;
      |            ^~~~~~~~~
---->8----

If I just invert those two options to:

----8<----
-DUSE_SYSTEMD=ON
-DENABLE_JOURNALD_LOG=ON
---->8----
(everything else unchanged)

the build completes successfully.

I do not use systemd (although I have it available in a non standard
location), so, if disabling those two options is still supported, I
think this should be fixed

I remember a similar problem in the past:
https://bugs.webkit.org/show_bug.cgi?id=253635

many thanks in advance for your valuable work and for any help

ciao
-gabriele


Complete list of options I use:

-DPORT=GTK
-DCMAKE_BUILD_TYPE=Release
-DENABLE_CREDENTIAL_STORAGE=OFF
-DENABLE_GEOLOCATION=OFF
-DUSE_LIBNOTIFY=OFF
-DUSE_LIBHYPHEN=OFF
-DENABLE_FTL_JIT=ON
-DUSE_WOFF2=OFF
-DENABLE_JIT=ON
-DUSE_OPENJPEG=OFF
-DUSE_WPE_RENDERER=OFF
-DENABLE_BUBBLEWRAP_SANDBOX=OFF
-DUSE_SYSTEMD=OFF
-DENABLE_GAMEPAD=OFF
-DUSE_LD_GOLD=OFF
-DUSE_SOUP2=OFF
-DENABLE_JOURNALD_LOG=OFF
-DENABLE_WAYLAND_TARGET=OFF
-DUSE_AVIF=OFF
-DUSE_JPEGXL=OFF
-DUSE_LIBBACKTRACE=OFF

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20231223/8bbfec54/attachment-0001.htm>