[Webkit-unassigned] [Bug 266260] New: Inline SVGTextLayoutAttributes::emptyValue

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=266260

            Bug ID: 266260
           Summary: Inline SVGTextLayoutAttributes::emptyValue
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: SVG
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: rbuis at igalia.com, sabouhallawa at apple.com,
                    simon.fraser at apple.com, zimmermann at kde.org

Hi Team,

While looking into Blink's commit, I came across another potential merge:

Blink Commit: https://src.chromium.org/viewvc/blink?view=revision&revision=195555

"This function just returns a simple float - inlining it allows the
compiler to generate more efficient code (and smaller - ~.5k) code
since the relatively high overhead call can be eliminated.
Take the opportunity to change the "empty value" into NaN (instead of
"max() - 1"), with corresponding semantic changes required by that."

Just wanted to raise to get input, if it is worthwhile change to merge.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20231212/1f154bbb/attachment-0001.htm>