[Webkit-unassigned] [Bug 265952] AX: insertionPointLineNumber hits the main thread even for single-line text fields

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 7 12:06:14 PST 2023


https://bugs.webkit.org/show_bug.cgi?id=265952

--- Comment #8 from Andres Gonzalez <andresg_22 at apple.com> ---
(In reply to Dominic Mazzoni from comment #6)
> Fixed auto*, renamed to isSingleLineTextField, and got rid of the compound
> if statement.
> 
> > AG: it would be clearer to have this method return an enum, something like
> > enum class : uint_8 { Unknown, SingleLine, MultiLine }.
> 
> I'm not a fan of computing things that aren't actually used. Is this okay
> as-is or maybe would there be a way to rename the function?

AG: maybe canBeMultiline() ? And then check for the negation in the optimization.

> 
> Interestingly, it looks like there are no Mac accessibility APIs that expose
> multiline directly. On Windows and Linux text fields have a native multiline
> accessibility attribute.

Yes, that's quite an omission that has a user experience impact.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20231207/33915c44/attachment.htm>


More information about the webkit-unassigned mailing list