[Webkit-unassigned] [Bug 265891] New: Remove strange parentElement() code from HitTestResult

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=265891

            Bug ID: 265891
           Summary: Remove strange parentElement() code from HitTestResult
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: bfulgham at webkit.org, simon.fraser at apple.com,
                    zalan at apple.com

Hi Team,

While looking through clean-ups, I came across another potential from Blink's commit:

Blink Commit: https://chromium.googlesource.com/chromium/blink/+/ceea705be631379fd0d012d4f20128ad3e7296ea

"This code doesn't make any sense, why would the parentElement() be in
the document if the node wasn't?

It came from http://src.chromium.org/viewvc/blink?view=revision&revision=23994
7 years ago when the HitTestResult was actually stored in the Event, but
even then it doesn't seem to make sense."

WebKit Source: https://searchfox.org/wubkat/rev/1a7afa1ea1ff078e0856c604cc572aa47d35f2eb/Source/WebCore/rendering/HitTestResult.cpp#796

Just wanted to raise to get input so we can do this clean-up.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20231205/23eaff4e/attachment.htm>